Use Sequence[ModelMessage] instead of list for method arg types
#3040
+70
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moritzwilksch I think we can also do this in the |
moritzwilksch
commented
Oct 1, 2025
DouweM
requested changes
Oct 1, 2025
DouweM
changed the title
Sequence[ModelMessage] for .direct functions arg typesSequence[ModelMessage] instead of list for method arg types
moritzwilksch
force-pushed
the
mw/minimal-seq-typing
branch
from
62b9467 to
0313ad4
Compare
DouweM
requested changes
Oct 3, 2025
|
thanks, changed. |
Kludex
approved these changes
Oct 6, 2025
|
@moritzwilksch Please merge main and update the new |
moritzwilksch
force-pushed
the
mw/minimal-seq-typing
branch
from
c44e8a8 to
8509865
Compare
|
@moritzwilksch Thanks Moritz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up on #2941, this would be a minimally invasive change that at least fixes typing for the direct functions without touching
Modelor its subclasses which would trigger a cascade of required typing changes since most other functions rely onModel.request